Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce Multi-Process aware Logger
What does this add?
Adds a new
LoggerAdapter
and aget_logger
helper to help aid with printing logs repeatedly when in multiprocessWhy is it needed?
Users were reporting that the logs can confuse them with the actions actually occuring (such as logging multiple times a model was saved even though it only happened once).
Rather than an onslaught of if statements, this PR takes the simpler approach of creating an Adapter that will do the check for us.
By default it will only log to the main processor, but if all processes should log just pass
main_process_only=False
(see examples below)What parts of the API does this impact?
User-facing:
Loggers in Accelerate now accept a
main_process_only
kwargBasic Usage Example(s):