Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix fdsp config in cluster #331

Merged
merged 3 commits into from
Apr 28, 2022
Merged

Fix fdsp config in cluster #331

merged 3 commits into from
Apr 28, 2022

Conversation

muellerzr
Copy link
Collaborator

fsdp_config doesn't have a default None value and will raise an issue if you aren't using DistributedType.MULTI_GPU

Traceback (most recent call last):
  File "/opt/conda/bin/accelerate", line 8, in <module>
    sys.exit(main())
  File "/opt/conda/lib/python3.8/site-packages/accelerate/commands/accelerate_cli.py", line 43, in main
    args.func(args)
  File "/opt/conda/lib/python3.8/site-packages/accelerate/commands/config/__init__.py", line 64, in config_command
    config = get_user_input()
  File "/opt/conda/lib/python3.8/site-packages/accelerate/commands/config/__init__.py", line 37, in get_user_input
    config = get_cluster_input()
  File "/opt/conda/lib/python3.8/site-packages/accelerate/commands/config/cluster.py", line 165, in get_cluster_input
    fsdp_config=fsdp_config,
UnboundLocalError: local variable 'fsdp_config' referenced before assignment

@muellerzr muellerzr added the bug Something isn't working label Apr 28, 2022
@muellerzr muellerzr requested a review from sgugger April 28, 2022 19:26
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Apr 28, 2022

The documentation is not available anymore as the PR was closed or merged.

Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing!

src/accelerate/commands/config/cluster.py Outdated Show resolved Hide resolved
@muellerzr muellerzr merged commit 7d2a259 into main Apr 28, 2022
@muellerzr muellerzr deleted the hotfix_config branch April 28, 2022 20:01
sgugger added a commit that referenced this pull request Apr 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants