Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Utils] align_module_device #3204

Merged
merged 11 commits into from
Nov 1, 2024

Conversation

kylesayrs
Copy link
Contributor

@kylesayrs kylesayrs commented Oct 29, 2024

Purpose

  • Add an align_module utility function which temporarily moves a module's parameters to its execution device. The execution device may be overwritten and defaults to the execution device of the AlignDevicesHook if present
  • Prepare for other utility functions to be implemented in future PRs

Changes

  • Implement utility function in accelerate.utils.modeling, exposed through accelerate.utils
  • Replace repeat code use in accelerate.utils.modeling and with newly added function

Testing

  • Added tests in tests/test_modeling_utils.py.py

Who can review?

@SunMarc
@LysandreJik
@muellerzr
@mgoin

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@LysandreJik LysandreJik requested a review from muellerzr October 30, 2024 15:57
Copy link
Collaborator

@muellerzr muellerzr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the tests! Overall this looks great to me, I left a few readability suggestions 🤗

src/accelerate/utils/modeling.py Outdated Show resolved Hide resolved
src/accelerate/utils/modeling.py Outdated Show resolved Hide resolved
src/accelerate/utils/modeling.py Outdated Show resolved Hide resolved
@kylesayrs
Copy link
Contributor Author

@muellerzr Thank you for the suggestions!

Copy link
Member

@BenjaminBossan BenjaminBossan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for providing this new utility function, it makes a lot of sense to me. Also, nice tests.

I just some smaller comments, no blocker.

src/accelerate/utils/modeling.py Outdated Show resolved Hide resolved
src/accelerate/utils/modeling.py Outdated Show resolved Hide resolved
src/accelerate/utils/modeling.py Outdated Show resolved Hide resolved
src/accelerate/utils/modeling.py Outdated Show resolved Hide resolved
src/accelerate/utils/modeling.py Show resolved Hide resolved
@kylesayrs kylesayrs changed the title [Utils] align_module [Utils] align_module_device Oct 31, 2024
@muellerzr muellerzr merged commit bf4572b into huggingface:main Nov 1, 2024
25 checks passed
@kylesayrs kylesayrs deleted the neural-magic/align_module branch November 1, 2024 16:05
Copy link
Member

@SunMarc SunMarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice utility function ! Thanks for adding it !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants