-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Utils] align_module_device
#3204
[Utils] align_module_device
#3204
Conversation
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding the tests! Overall this looks great to me, I left a few readability suggestions 🤗
Co-authored-by: Zach Mueller <[email protected]>
Co-authored-by: Zach Mueller <[email protected]>
Co-authored-by: Zach Mueller <[email protected]>
@muellerzr Thank you for the suggestions! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for providing this new utility function, it makes a lot of sense to me. Also, nice tests.
I just some smaller comments, no blocker.
Co-authored-by: Benjamin Bossan <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice utility function ! Thanks for adding it !
Purpose
align_module
utility function which temporarily moves a module's parameters to its execution device. The execution device may be overwritten and defaults to the execution device of the AlignDevicesHook if presentChanges
accelerate.utils.modeling
, exposed throughaccelerate.utils
accelerate.utils.modeling
and with newly added functionTesting
tests/test_modeling_utils.py.py
Who can review?
@SunMarc
@LysandreJik
@muellerzr
@mgoin