Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Leave default as None in mixed_precision for launch command #300

Merged
merged 1 commit into from
Mar 30, 2022

Conversation

sgugger
Copy link
Collaborator

@sgugger sgugger commented Mar 30, 2022

The default in mixed_precision for the launch command should be None, otherwise the config value is not used. Thanks @nbroad1881 for reporting the bug!

@sgugger sgugger requested a review from muellerzr March 30, 2022 17:40
Copy link
Collaborator

@muellerzr muellerzr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Mar 30, 2022

The documentation is not available anymore as the PR was closed or merged.

@sgugger sgugger merged commit f03f182 into main Mar 30, 2022
@sgugger sgugger deleted the fix_mixed_precision branch March 30, 2022 17:48
sgugger added a commit that referenced this pull request Mar 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants