-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a SLURM example with minimal config #2950
Conversation
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding this ! Maybe in a future PR, we can add a section in accelerate on what this script does line by line !
export LAUNCHER="accelerate launch \ | ||
--config ${ACCELERATE_DIR}/examples/slurm/fsdp_config.yaml \ | ||
--num_processes $((SLURM_NNODES * GPUS_PER_NODE)) \ | ||
--num_machines $SLURM_NNODES \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
$SLURM_NNODES is not set
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That just "exists" in a SLURM node :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Slurm magic 🪄😂 Sounds good ! I've never ran multi node with slurm, so i didn't know.
This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread. Please note that issues that do not follow the contributing guidelines are likely to be ignored. |
Co-authored-by: Marc Sun <[email protected]>
What does this PR do?
This PR adds a new SLURM example specifically for when users want to specify an
accelerate
config yaml in addition to regular launching. This is specifically useful as generally SLURM resources are dynamically created/set in SLURM, such as:However since we only care about these values, this PR shows how you can also pass in a config yaml (if it's stored somewhere locally/on a shared FS):
With that config file being extremely minimal:
Fixes # (issue)
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.
@SunMarc