Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add XLA Dynamo backends for training and inference #2892

Merged
merged 1 commit into from
Jul 3, 2024

Conversation

johnsutor
Copy link
Contributor

What does this PR do?

This PR introduces the TorchDynamo integration with PyTorch XLA. Though I haven't thorougly benchmarked the code, it works on the CLM example from the Transformers library, when spawned using the accelerate launch command on a v5e TPU VM with 8 TPUs running on Ubuntu 22.04. It also passes all tests I ran on the TPU.

Fixes #2870

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@SunMarc

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Member

@SunMarc SunMarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this @johnsutor ! cc @muellerzr for visibility

@SunMarc SunMarc requested a review from muellerzr June 26, 2024 11:16
Copy link
Collaborator

@muellerzr muellerzr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks for enabling this :)

@muellerzr muellerzr merged commit 57a4c74 into huggingface:main Jul 3, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for Torch XLA Dynamo Backend
4 participants