Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use proper size #21

Merged
merged 1 commit into from
Mar 29, 2021
Merged

Use proper size #21

merged 1 commit into from
Mar 29, 2021

Conversation

sgugger
Copy link
Collaborator

@sgugger sgugger commented Mar 29, 2021

The size used inside the pad_across_processes function was wrong, this PR fixes that.

@sgugger sgugger requested a review from LysandreJik March 29, 2021 14:59
LysandreJik
LysandreJik approved these changes Mar 29, 2021
View reviewed changes
Copy link
Member

@LysandreJik LysandreJik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sgugger sgugger merged commit d46d1e8 into main Mar 29, 2021
@sgugger sgugger deleted the fix_pad_across_processes branch March 29, 2021 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LysandreJik LysandreJik LysandreJik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sgugger @LysandreJik