Skip to content

Commit

Permalink
Add set_to_none to AcceleratedOptimizer.zero_grad (#43)
Browse files Browse the repository at this point in the history
  • Loading branch information
sgugger authored Apr 23, 2021
1 parent 4d8a2f6 commit e0a420f
Showing 1 changed file with 14 additions and 2 deletions.
16 changes: 14 additions & 2 deletions src/accelerate/optimizer.py
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,8 @@

import torch

from packaging import version

from .state import AcceleratorState, DistributedType, is_tpu_available


Expand Down Expand Up @@ -86,8 +88,18 @@ def load_state_dict(self, state_dict):
def state_dict(self):
return self.optimizer.state_dict()

def zero_grad(self):
self.optimizer.zero_grad()
def zero_grad(self, set_to_none=None):
if version.parse(torch.__version__) < version.parse("1.7.0"):
if set_to_none is not None:
raise ValueError(
"`set_to_none` for Optimizer.zero_grad` was introduced in PyTorch 1.7.0 and can't be used for "
f"earlier versions (found version {torch.__version__})."
)
self.optimizer.zero_grad()
else:
if set_to_none is not None:
set_to_none = False
self.optimizer.zero_grad(set_to_none=set_to_none)

def step(self):
if self.state.distributed_type == DistributedType.TPU:
Expand Down

0 comments on commit e0a420f

Please sign in to comment.