Skip to content

Commit

Permalink
Add signature check for set_to_none in Optimizer.zero_grad (#189)
Browse files Browse the repository at this point in the history
  • Loading branch information
sgugger authored Oct 20, 2021
1 parent 7542176 commit 39a0b30
Showing 1 changed file with 11 additions and 3 deletions.
14 changes: 11 additions & 3 deletions src/accelerate/optimizer.py
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,8 @@
# See the License for the specific language governing permissions and
# limitations under the License.

import inspect

import torch

from packaging import version
Expand Down Expand Up @@ -100,9 +102,15 @@ def zero_grad(self, set_to_none=None):
)
self.optimizer.zero_grad()
else:
if set_to_none is None:
set_to_none = False
self.optimizer.zero_grad(set_to_none=set_to_none)
accept_arg = "set_to_none" in inspect.signature(self.optimizer.zero_grad).parameters
if accept_arg:
if set_to_none is None:
set_to_none = False
self.optimizer.zero_grad(set_to_none=set_to_none)
else:
if set_to_none is not None:
raise ValueError("`set_to_none` for Optimizer.zero_grad` is not supported by this optimizer.")
self.optimizer.zero_grad()

def step(self, closure=None):
if self.state.distributed_type == DistributedType.TPU:
Expand Down

0 comments on commit 39a0b30

Please sign in to comment.