Reuse SecretManagerServiceClient instance in DefaultGcpSecretSupplier #440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
During startup profiling I found we spend 600ms (on my computer) repeatedly creating this secrets manager client for each use. We should be able to hold a common instance in the supplier class.
hudson155
reviewed
Feb 12, 2025
| @@ -9,13 +9,17 @@ import kairo.protectedString.ProtectedString | |||
|
|
|||
| private val logger: KLogger = KotlinLogging.logger {} | |||
|
|
|||
| public object DefaultGcpSecretSupplier : GcpSecretSupplier() { | |||
There was a problem hiding this comment.
Why do we want/need to switch this from an object to a class?
There was a problem hiding this comment.
I just shy away from stateful objects, but if you prefer I can change it
hudson155
approved these changes
Feb 13, 2025
| @@ -9,13 +9,17 @@ import kairo.protectedString.ProtectedString | |||
|
|
|||
| private val logger: KLogger = KotlinLogging.logger {} | |||
|
|
|||
| public object DefaultGcpSecretSupplier : GcpSecretSupplier() { | |||
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
During startup profiling I found we spend 600ms (on my computer) repeatedly creating this secrets manager client for each use. We should be able to hold a common instance in the supplier class.
Checklist