Require explicit MIME type for Respons#parse #540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ixti
force-pushed
the
ixti/remove-parse-implicitness
branch
from
a23a4e1 to
36fd9e5
Compare
guidojw
added a commit
to csvalpha/amber-api
that referenced
this pull request
May 19, 2021
Matthijsy
pushed a commit
to csvalpha/amber-api
that referenced
this pull request
May 26, 2021
* Update http to version 5.0.0 * Update webmock To version that supports http 5.0.0 * specify MIME type on response.parse Ref: httprb/http#540 Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com> Co-authored-by: Guido de Jong <[email protected]>
DannyBen
added a commit
to DannyBen/http
that referenced
this pull request
May 26, 2021
Merged
rsanheim
added a commit
to simpledotorg/simple-server
that referenced
this pull request
Oct 20, 2021
HTTP has a built in parse method we can use, we just have to provide the content type that we are expecting see httprb/http#540
rsanheim
added a commit
to simpledotorg/simple-server
that referenced
this pull request
Oct 20, 2021
* Update http gem to 5.0.4 To get to a fixed version for arm m1 macs The latest version of the http gem drops http-parser for llhttp, which has broader compatibility, as well as including a whole host of other fixes in http itself. see https://github.com/httprb/http/blob/main/CHANGES.md for details re: #1969 re: httprb/http#630 * Update Exotel usage for latest HTTP gem HTTP has a built in parse method we can use, we just have to provide the content type that we are expecting see httprb/http#540 * Update specs for latest version of HTTP gem / user-agent
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #538