Get the request object from the response?

[thegreyfellow]

Is it possible to get the request object from the response?
Sometimes if not always when debugging if a response failed I need to know if I missed something on the request body or headers, but now I have no way to do that. if there is any work around that would be great.

Thanks.

---

HTTPrb v3.0.0
ruby v2.3.5

[ixti]

It's not doable atm - response has no "knowledege" of request (except request URI) - but in face of thinking about next major version update I really think we should change that. I also find it pretty useful to be able to get request object that was used to get response.

[ixti]

You can "monkey-patch" client for your needs atm though:

module HTTP
  class Request
    attr_accessor :req
  end

  class Client
    def perform(req, options)
      super(req, options).tap { |res| res.req = req }
    end
  end
end

[thegreyfellow]

Thanks for the quick response, not sure how to use this piece of code though, I tried to include it inside the classe where I require 'http' but I get this error:

NoMethodError (super: no superclass method `perform' for #<HTTP::Client:0x00007fad94d1c358>):

[ixti]

Oh. Sorry. I was thinking about different approach and forgot to "adapt" it to a more generic solution. Was thinking about re-defining perform on client instance... Anyway here's working example:

module HTTP
  class Response
    attr_accessor :req
  end

  class Client
    alias_method :__perform__, :perform

    def perform(req, options)
      __perform__(req, options).tap { |res| res.req = req }
    end
  end
end

[thegreyfellow]

Thanks that worked! I agree this feature would be very interesting to have, it will aid in debugging a lot. Any ideas on where to start, to implement it in the gem?

[ixti]

It's in fact trivial to implement in the gem, so instead of passing only uri keyword to response, we can pass whole request:

https://github.com/httprb/http/blob/master/lib/http/client.rb#L74-L83

Obviosuly, Response needs to be updated to match this change as well. This will be a massive backward incompatible change - but that's fine for next (4.x) releases.

/cc @httprb/core

[thegreyfellow]

Awesome! that would be great to see it happen in v4.x. Thanks @ixti :)

[uberllama]

Any movement on this? Part of my requirement in choosing an HTTP lib is that I can easily dump out both the assembled request and the response to database audit columns. As it stands, I have to build up a request manually from an outer wrapper that takes the args I will pass to httprb.

[kris]

I really enjoy working with this library, except for the lacking debug of the request object. Any movement on this (outside of a monkey patch) would be great.

[tarcieri]

If @joshuaflanagan can update #546 I'd consider merging it