Lints #704
Merged
Lints #704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yoshuawuyts
force-pushed
the
lints
branch
2 times, most recently
from
5065aa9 to
798a247
Compare
|
I've disabled the router bench temporarily; we don't really use it much anymore since the router has been optimized, but can always spin it back up if we want to. |
|
And I've restored the router bench. All |
yoshuawuyts
force-pushed
the
lints
branch
2 times, most recently
from
35d67eb to
18c7920
Compare
Fishrock123
previously approved these changes
Sep 28, 2020
taiki-e
reviewed
Sep 29, 2020
taiki-e
reviewed
Sep 29, 2020
|
See also http-rs/async-sse#11 |
Fishrock123
dismissed
their stale review
forbidding rust 2018 idioms does not seem like the best idea.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds various lints and fixes our implementations. This ensures items are always documented and we don't miss any in CI. Thanks!