-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
What is the point of the 'secure' option #866
Comments
Fixed it by adding: if(options.ca){ in common.js inside function common.setupOutgoing Now it is working, but this should really be added to this project |
@Marc477 pull-requests very much welcome |
I just found out that if a put all the certificate chain in my .crt file, I don't need to add it as ca parameter to https request ! But self-signed certificates are still a mystery for me since i always get the error: UNABLE_TO_VERIFY_LEAF_SIGNATURE, even after adding it to ca param |
Ok we need to add CA to server too, so we need to add CA option to http-proxy for self-signed certificates |
While using secure: true for proxy connections, there is no way to pass the trusted root CA(s) or intermediate CA(s). This change allows that to be passed in the httpProxy createServer options and used for the outgoing proxy connection.
What is the point of the 'secure' if the module only works (in https) when it is set to false ??
In an https.request, when we set rejectUnauthorized to true we also have to set the ca (certificate authority file), otherwise the certificate will fail validating. But there is no way to set https.request ca option in http-proxy.
The text was updated successfully, but these errors were encountered: