Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

force to use ecstatic v3.3.2 in tests #574

Merged
merged 2 commits into from
Nov 11, 2019

Conversation

Xmader
Copy link
Contributor

@Xmader Xmader commented Nov 9, 2019

Please ensure that your pull request fulfills these requirements:

  • The pull request is being made against the master branch
  • Tests for the changes have been added (for bug fixes / features)

What is the purpose of this pull request? (bug fix, enhancement, new feature,...)

force to use ecstatic v3.3.2 in tests

Same as #525 (comment), the version of ecstatic used in tests is different from it when installing http-server globally or as a dependency.

#525 only appears when using ecstatic v3.3.2 .
It is very confusing in tests.

What changes did you make?

change the version of ecstatic in package-lock.json to 3.3.2

@Xmader Xmader changed the title force to install ecstatic v3.3.2 in tests force to use ecstatic v3.3.2 in tests Nov 9, 2019
@Xmader
Copy link
Contributor Author

Xmader commented Nov 9, 2019

To ensure every package used in tests are the same version as installing http-server globally or as a dependency, just delete package-lock.json , or include package-lock.json in npm pack (Xmader@42d7f90).

@thornjad
Copy link
Member

Including the package lock in the npm package defeats the purpose of the package lock, doesn't it? In this case could we just bump the dependency in the package.json to ^3.3.2?

@thornjad thornjad added this to the v0.12.0 milestone Nov 11, 2019
@thornjad thornjad merged commit 9a0f64f into http-party:master Nov 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants