-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No matching version found for ecstatic@^3.0.0 #521
Comments
I'm only seeing one version on |
Looks like ecstatic unpublished all but the latest version. However, the latest version has breaking changes which totally breaks right now #520 |
https://www.npmjs.com/advisories/830 Open Redirect vuln was the cause of removals. |
@thornjad Do we have a list of breaking changes? If we can set up a branch I can pitch in fixing some of them |
@thornjad I see there are some changes that might have some impact in the changelog:
I suspect that the change is indeed in the mimetype and charset handling somewhere. I'm running some tests as well. |
Will do. Right now I am just as confused though 🤔 |
For the immediate issue of a lack of ecstatic v3, jfhbrook/node-ecstatic#256 |
Is a release of http-server that uses a fixed branch/release of node-ecsatic planned? |
@nolman #522. When jfhbrook/node-ecstatic#256 releases, it should also fix the redirect vulnerability. |
A dependency of http-server was removed from npm. As a result, all http-server installations currently fail. While we wait for a fix, we can temporarily remove our usage of http-server. Only the `happo debug` command is affected, which I think is okay. Fixes #73 See http-party/http-server#521 for context.
A dependency of http-server was removed from npm. As a result, all http-server installations currently fail. While we wait for a fix, we can temporarily remove our usage of http-server. Only the `happo debug` command is affected, which I think is okay. Fixes #73 See http-party/http-server#521 for context.
This was blocking our CI pipeline, I created a fork of this library on NPM with the fix back ported if someone else is stuck on this you can install it via |
Thanks @nolman |
Thanks @nolman |
Well, this just neatly took down our entire CI pipeline... where the server is not even spun up. It also meant any developers running local dev servers who were unfortunate enough to have to re I know its not http-server's fault, but at a minimum I think for something like this ecstatic should of at least provided an update to 3.x.x which was usable. thanks to @nolman for |
This also broke all of our builds during an unfortunate time... If you are using Old "scripts": {
"serve": "http-server --cors -c-1 -o -p 9966 example -a localhost"
} New "scripts": {
"serve": "npx http-server-legacy --cors -c-1 -o -p 9966 example -a localhost"
} Thanks @nolman for the quick turnaround 👍 |
edit: ooooof it's slow I'd like to switch to npm's http-server: https://stackoverflow.com/questions/12905426/what-is-a-faster-alternative-to-pythons-http-server-or-simplehttpserver https://www.npmjs.com/package/http-server but there's a dep error right now b/c of a security thing with a dep. See also http-party/http-server#521 jfhbrook/node-ecstatic#256 (comment)
An idea would be to release a new version of http-server that depends directly on the estatic repository, with the commit being used to reference the right version. |
I have tried |
the same to me I have tried npm i http-server-legacy, but is not working to run the server |
Ecstatic has published a version 3.3.2 (jfhbrook/node-ecstatic#256 (comment))! I just tested, and http-server should install now! However, because of all this, in the future we may want to replace ecstatic. I've started working on a fork of ecstatic which we may be able to use. I'm still getting CI running, though, and I haven't published yet. For now, all should be back to normal |
I confirm that CI build is working back with new 3.3.2 version |
npm install apiconnect still fails with ecstatic 3.3.1 dependency
|
For anyone that might have the same issue I had. I could not use npx because my container wouldn't download packages after it was deployed for some restrictions set by the ops team. I changed the Dockerfile to contain something like this
but the
thanks again to @nolman for the fix it worked out great for me and my team. |
@thornjad |
After typing
npm install
I get the following:The text was updated successfully, but these errors were encountered: