Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chinese language, fixes and minor updates #12

Merged
merged 9 commits into from
Jan 28, 2023
Merged

Chinese language, fixes and minor updates #12

merged 9 commits into from
Jan 28, 2023

Conversation

uuidev
Copy link
Collaborator

@uuidev uuidev commented Jan 27, 2023 •
edited
Loading

What was done

  • Add Chinese language
  • Arrange languages in README.md in alphabetical order
  • Add one line between header & name in LICENSE in every file
  • Delete header file (there is no need for it)
  • Fix showing emojis in the arrow (check details)
  • Remove UIKit from a non-UI service

Implementation details

There was a bug when scrolling, in the arrow to source view we can see emojis

Bug

The version was updated to 3.0.8

@uuidev
Copy link
Collaborator Author

uuidev commented Jan 27, 2023

Thanks again for your help with syncing my fork

uuidev added 2 commits January 27, 2023 13:53
@uuidev
fix: arrow for source view
40769a3 
Experimentally I found this solution, it may be some kind of crutch, sorry :)
@uuidev
refactor: remove importing & using UIKit in non-ui service
c193cab
@uuidev uuidev changed the title Chinese language and minor updates Chinese language, fixes and minor updates Jan 27, 2023
@htmlprogrammist
Copy link
Owner

Please, change target branch from main to develop. There are some updates, it would be much easier for me

@htmlprogrammist
Copy link
Owner

It's my pleasure. Thank you again for contributing @uuidev!

@uuidev uuidev changed the base branch from main to develop January 28, 2023 07:27
@htmlprogrammist htmlprogrammist self-requested a review January 28, 2023 08:34
htmlprogrammist
htmlprogrammist reviewed Jan 28, 2023
View reviewed changes
Copy link
Owner

@htmlprogrammist htmlprogrammist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything is fine. No need for further updates

@htmlprogrammist htmlprogrammist merged commit 3acbbc7 into htmlprogrammist:develop Jan 28, 2023
@htmlprogrammist htmlprogrammist mentioned this pull request Jan 28, 2023
Merged
@htmlprogrammist htmlprogrammist added ♻️ refactor Code refactoring 🛠 fix Major/minor fixes 🇺🇳 localization Add localization to the project 🧬 fork Contributing labels Feb 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@htmlprogrammist htmlprogrammist htmlprogrammist left review comments

Assignees
No one assigned
Labels
🛠 fix Major/minor fixes 🧬 fork Contributing 🇺🇳 localization Add localization to the project ♻️ refactor Code refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@uuidev @htmlprogrammist