This repository was archived by the owner on Dec 31, 2020. It is now read-only.
Update to 0.6.7 #15
Merged
Update to 0.6.7 #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
April 26, 2016 19:00
- introduce NetworkInference because the Inference object is proving too big to use as a data flow element.
| } | ||
| for(Class<?> c : KryoSerializer.ADDITIONAL_REGISTERED_TYPES) { | ||
| config.registerTypeWithKryoSerializer(c, (Class<? extends Serializer<?>>) (Class<?>) KryoSerializer.class); | ||
| Class<?> serializerClass = DEFAULT_SERIALIZERS.getOrDefault(c, (Class<?>) KryoSerializer.class); | ||
| config.registerTypeWithKryoSerializer(c, (Class<? extends Serializer<?>>) serializerClass); | ||
| } | ||
| } | ||
|
|
||
| static final Class<?>[] ADDITIONAL_REGISTERED_TYPES = { Network.class }; |
There was a problem hiding this comment.
As far as I can tell there is no reason to register the Network object. Internally, all registering does is share the class name (string) among all instances of that particular class (which is slower). So pre-registering helps avoid this behavior, but since there is only ever one instance of the Network, I don't see how registering it will be any more efficient because there is only ever one of its type being serialized?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.