Add null violation checks for std::unique_ptr
, std::shared_ptr
, std::optional
and std::expected
to prevent UB
#945
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
assert_not_null
now verifiesstd::unique_ptr
,std::shared_ptr
,std::optional
andstd::expected
in addition to the original null pointer check.These states are considered to be "null" and will result in a violation error if dereferenced or accessed:
std::unique_ptr
that owns nothingstd::shared_ptr
with no managed objectstd::optional
with no valuestd::expected
containing an unexpected valueNull violation errors will be reported in the following cases:
Add new regression tests: