Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Add clang++-12 regression tests run on Ubuntu #936

Merged
merged 2 commits into from
Jan 16, 2024

Conversation

jarzec
Copy link
Contributor

@jarzec jarzec commented Jan 12, 2024

The current regression tests workflow is missing a run using clang++-12.
This PR adds this compiler and updates the respective tests.

Note that this branch is based on #935, which should be merged first.

@@ -19,6 +19,8 @@ jobs:
os: [ubuntu-latest]
compiler: [g++-10, g++-13]
include:
- os: ubuntu-20.04
compiler: clang++-12
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang++-12 is not installed by default on the ubuntu-latest image, but it is on ubuntu-20.04, so this is the easiest way to include it.

@hsutter
Copy link
Owner

hsutter commented Jan 13, 2024

Thanks! @JohelEGP @jarzec @bluetarpmedia I see a few apparently-related PRs by the three of you, is there an order they should be merged?

@JohelEGP
Copy link
Contributor

By their PR number should work OK.

@JarekGlobus
Copy link

Thanks! @JohelEGP @jarzec @bluetarpmedia I see a few apparently-related PRs by the three of you, is there an order they should be merged?

@hsutter To be more precise:

@hsutter hsutter merged commit aee3816 into hsutter:main Jan 16, 2024
12 of 15 checks passed
@hsutter
Copy link
Owner

hsutter commented Jan 16, 2024

Thanks!

@jarzec jarzec deleted the ci-add-clang++-12-on-ubuntu branch January 16, 2024 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants