fix(cpp1): emit requires clause in forward declaration #486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaxSagebaum
reviewed
Jun 2, 2023
Co-authored-by: Max Sagebaum <[email protected]> Signed-off-by: Johel Ernesto Guerrero Peña <[email protected]>
|
The added test will fail for GCC10. |
|
Without this, one can't write usable constrained overloads in Cpp2. |
|
Looks good, thanks! |
Signed-off-by: Herb Sutter <[email protected]>
zaucy
pushed a commit
to zaucy/cppfront
that referenced
this pull request
Dec 5, 2023
* fix(cpp1): emit requires clause in forward declaration * refactor: prevent warning on token-eating macro Co-authored-by: Max Sagebaum <[email protected]> Signed-off-by: Johel Ernesto Guerrero Peña <[email protected]> * test: add `test-results/gcc-13` * Delete gcc-version.output Signed-off-by: Herb Sutter <[email protected]> --------- Signed-off-by: Johel Ernesto Guerrero Peña <[email protected]> Signed-off-by: Herb Sutter <[email protected]> Co-authored-by: Max Sagebaum <[email protected]> Co-authored-by: Herb Sutter <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #323.
See it working:
GCC 10 can never work in type scope: https://cpp2.godbolt.org/z/a7Pq6exdj.
Testing summary.
Acknowledgements.