Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI Update test outputs #1303

Closed
wants to merge 1 commit into from
Closed

Conversation

jarzec
Copy link
Contributor

@jarzec jarzec commented Oct 7, 2024

Updates outdated regression test output files.
Test failures to be addressed separately.

@JohelEGP
Copy link
Contributor

JohelEGP commented Oct 7, 2024

#1291 addresses one such failure.

@jarzec
Copy link
Contributor Author

jarzec commented Oct 8, 2024

#1291 addresses one such failure.

Well, I was rather thinking about fixing the code than modifying the tests to make the faulty code pass.
There is actually an LLVM bug I've reported that affects all (almost all) the Clang versions we use. Nevertheless an elegant workaround modifying the code itself seems achievable.

EDIT: I just saw I didn't click "Update" on my edit, so here it goes: on a second though a mod of the test could serve as a stepping stone making all tests pass until a better solution is available. I guess that would be @hsutter's call.

@JohelEGP
Copy link
Contributor

Well, I was rather thinking about fixing the code than modifying the tests to make the faulty code pass.
There is actually an LLVM bug I've reported that affects all (almost all) the Clang versions we use.

I do wonder.

I noticed this while working on #526,
before requiring parameters to be named _,
and lowering only the parameter's type.

I'm fairly sure that, at the time,
I checked with the C++ Standard whether Clang was right.
I think I found out Clang was indeed right,
and as a result I opened no compiler bugs.

@jarzec
Copy link
Contributor Author

jarzec commented Oct 21, 2024

Outdated, replaced with #1324

@jarzec jarzec closed this Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants