Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kafka(cli): set isolation level to read_uncommited #1734

Merged
merged 2 commits into from
Jan 10, 2024
Merged

kafka(cli): set isolation level to read_uncommited #1734

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8685edf
kafka(cli): set isolation level to read_uncommited
YangKian Jan 9, 2024
91ab92f
Merge branch 'main' into tttttttt
4eUeP Jan 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion hstream-kafka/HStream/Kafka/Server/Handler/Offset.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ import HStream.Kafka.Common.OffsetManager (getLatestOffset,
import HStream.Kafka.Common.Utils (mapKaArray)
import qualified HStream.Kafka.Group.GroupCoordinator as GC
import HStream.Kafka.Server.Types (ServerContext (..))
import qualified HStream.Logger as Log
import qualified HStream.Store as S
import qualified Kafka.Protocol as K
import qualified Kafka.Protocol.Error as K
Expand All @@ -37,7 +38,9 @@ pattern EarliestTimestamp = (-2)
handleListOffsets
:: ServerContext -> K.RequestContext -> K.ListOffsetsRequest -> IO K.ListOffsetsResponse
handleListOffsets sc reqCtx req
| reqCtx.apiVersion >= 2 && req.isolationLevel /= 0 = return $ mkErrResponse req
| reqCtx.apiVersion >= 2 && req.isolationLevel /= 0 = do
Log.warning $ "currently only support READ_UNCOMMITED(isolationLevel = 0) request."
return $ mkErrResponse req
| otherwise = listOffsets sc reqCtx req
where
mkErrResponse K.ListOffsetsRequest{..} =
Expand Down
1 change: 1 addition & 0 deletions hstream-kafka/cbits/hs_kafka_client.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -334,6 +334,7 @@ HsConsumer* hs_new_consumer(const char* brokers_, HsInt brokers_size_,
CONF_SET("group.id", std::string(group_id_, group_id_size_));
CONF_SET("auto.offset.reset", std::string(offset_reset_, offset_reset_size_));
CONF_SET("enable.auto.commit", auto_commit ? "true" : "false");
CONF_SET("isolation.level", "read_uncommitted");

std::string brokers(brokers_, brokers_size_);
CONF_SET("metadata.broker.list", brokers);
Expand Down