Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lookupNodePersist: wait for cluster epoch to sync before executing a new assignment #1676

Merged
merged 2 commits into from
Nov 10, 2023
Merged

Fix lookupNodePersist: wait for cluster epoch to sync before executing a new assignment #1676

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6978685
fix lookupNodePersist
daleiz Nov 9, 2023
8079faf
format
daleiz Nov 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 16 additions & 18 deletions common/server/HStream/Common/Server/Lookup.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,24 +64,22 @@ lookupNodePersist metaHandle gossipContext loadBalanceHashRing
case find ((nodeId == ) . A.serverNodeId) serverList of
Just theNode -> return theNode
Nothing -> do
(epoch', hashRing) <- readTVarIO loadBalanceHashRing
if epoch' > epoch
then do
theNode' <- getResNode hashRing key advertisedListenersKey
try (M.updateMeta @TaskAllocation metaId
(TaskAllocation epoch' (A.serverNodeId theNode'))
(Just version) metaHandle) >>= \case
Left (e :: SomeException) -> do
-- TODO: add a retry limit here
Log.warning $ "lookupNodePersist exception: " <> Log.buildString' e
<> ", retry..."
lookupNodePersist metaHandle gossipContext loadBalanceHashRing
key metaId advertisedListenersKey
Right () -> return theNode'
else do
let errmsg = "the server has not yet synced with the latest member list"
Log.warning $ "lookupNodePersist: " <> Log.buildString errmsg
throwIO $ HE.ResourceAllocationException errmsg
(epoch', hashRing) <- atomically $ do
(epoch', hashRing) <- readTVar loadBalanceHashRing
if epoch' > epoch
then pure (epoch', hashRing)
else retry
theNode' <- getResNode hashRing key advertisedListenersKey
try (M.updateMeta @TaskAllocation metaId
(TaskAllocation epoch' (A.serverNodeId theNode'))
(Just version) metaHandle) >>= \case
Left (e :: SomeException) -> do
-- TODO: add a retry limit here
Log.warning $ "lookupNodePersist exception: " <> Log.buildString' e
<> ", retry..."
lookupNodePersist metaHandle gossipContext loadBalanceHashRing
key metaId advertisedListenersKey
Right () -> return theNode'

data KafkaResource
= KafkaResTopic Text
Expand Down