arm64jit: Enable in UI #18229
Merged
arm64jit: Enable in UI #18229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unknownbrackets
added
the
arm64jit
5 tasks
|
I'm just gonna merge this now that the release process is "done", and if I can't figure out the M1 problem in the near future I'll just disable it again only on Mac. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For later, but once it's working on M1 I'd like to merge this to enable. It's all it takes.
For now I know it works fine on Qualcomm and Google Tensor processors. I suspect whatever's happening on M1 is actually macOS specific (or some non-pointerify mistake) but not sure.
-[Unknown]