Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GPU: Use accurate depth for depth range hack #16504

Merged
merged 1 commit into from
Dec 5, 2022

Conversation

unknownbrackets
Copy link
Collaborator

This should be easier to ensure stays well tested. Pretty sure this game doesn't really need clamp in the ways that some others do, and haven't heard of any reports of issues for Vulkan users without clamp.

I also think it might be the best option to do anything about #11732.

-[Unknown]

This should be easier to ensure stays well tested.
@unknownbrackets unknownbrackets added the Code Cleanup Cleanup to make future work easier. Needs to be done sometimes. label Dec 5, 2022
@hrydgard
Copy link
Owner

hrydgard commented Dec 5, 2022

Really good to get rid of that hack!

@hrydgard hrydgard merged commit 13e90f7 into hrydgard:master Dec 5, 2022
@hrydgard hrydgard added this to the v1.14.0 milestone Dec 5, 2022
@ghost
Copy link

ghost commented Dec 5, 2022

Confirmed this fixes Phantasy Star Portable 1 & 2 issues #11732 #13542

@unknownbrackets unknownbrackets deleted the psu-depth branch December 5, 2022 14:59
@hrydgard
Copy link
Owner

hrydgard commented Dec 5, 2022

Awesome, thanks for testing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code Cleanup Cleanup to make future work easier. Needs to be done sometimes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants