Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Savedata: Respect IO timing method setting #14837

Merged
merged 1 commit into from
Sep 12, 2021

Conversation

unknownbrackets
Copy link
Collaborator

With this, configuring IO timing method = Host will probably dodge any stutters on scoped storage save/load, but may be more hazardous if there's some game that expects specific timing. See #13847.

The current timing (always completes in one frame) is definitely wrong, but this is a quick change to validate my assumption that changes here could be an improvement. We should improve it, but that seems a bit more dangerous right now than extending this setting (which already has possible instability) to savedata, which it really should've always included.

-[Unknown]

@unknownbrackets unknownbrackets added this to the v1.12.0 milestone Sep 12, 2021
@hrydgard
Copy link
Owner

Let's just get this in, since (for now) it's host timing mode only.

I guess for fixed timing modes, we should later have a fixed delay of a couple more frames maybe, to get a better chance of covering I/O spikes.

@hrydgard hrydgard merged commit d2421eb into hrydgard:master Sep 12, 2021
@hrydgard hrydgard added the I/O Affected by I/O timing settings, or other kind of I/O issue. label Sep 12, 2021
@unknownbrackets unknownbrackets deleted the savedata-io branch September 13, 2021 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
I/O Affected by I/O timing settings, or other kind of I/O issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants