Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add labels to all UI views #14202

Merged
merged 6 commits into from
Feb 28, 2021
Merged

Conversation

unknownbrackets
Copy link
Collaborator

At this point, does nothing with them. However, this can be used to facilitate search or even accessibility.

I've exposed descriptions that should largely make sense as accessibility hints, i.e. labeling headings, buttons, etc. Lists would be very nice but aren't specifically handled - considering a dedicated LinearLayout subclass.

-[Unknown]

@unknownbrackets
Copy link
Collaborator Author

Okay, added lists and convenience describers for them. I don't think the describe functions for view groups would necessarily get called all that much for accessibility or search, but they seem pretty convenient for debugging. The semantics of have lists marked (compared to layout only) is useful, though.

-[Unknown]

@hrydgard hrydgard added the User Interface PPSSPP's own user interface / UX label Feb 28, 2021
@hrydgard hrydgard added this to the v1.12.0 milestone Feb 28, 2021
@hrydgard
Copy link
Owner

Yeah, this seems like it could be useful. Sorry I kinda forgot about this one :)

@hrydgard hrydgard merged commit 0fb655a into hrydgard:master Feb 28, 2021
@unknownbrackets unknownbrackets deleted the ui-labels branch February 28, 2021 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
User Interface PPSSPP's own user interface / UX
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants