Deinitialize Node.js properly #62
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luminosuslight
force-pushed
the
handle-scope-deinit
branch
from
2bbaea5 to
a4754b7
Compare
|
TODO: The deinitialize methods are not complete yet. |
Johannes-Schneider
changed the title
|
Applied changes in #67 |
msoechting
pushed a commit
that referenced
this pull request
Feb 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original Node: the HandleScope that contains all global objects was created on the stack in the Start() functions and destroyed when the scope of the Start() function was left
Before in Node Lib: the HandleScope was created as a static variable in the _CreateInitialEnvironment() function and destroyed only when the program exited
Idea: creating the HandleScope on the heap and delete it in Deinitialize()
Problem: HandleScopes can't be created on the heap
Workaround in this PR: adding a wrapper around the HandleScope, that can be created on the heap, and destroy this wrapper in Deinitialize()