Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes some issues. It also, yet again, reformats everything - I did this so I could use a common formatter on my diverged fork from felixmusmann/jointly, making getting my fixes much easier. I've added the formatter (
black
) as a GitHub action, so hopefully in the future no more divergent formatting will be considered.The list of issues this branch fixes is as following:
helpers/get_equidistant_signals
.INFO
- probably something similar to the problem above, since aMemoryError
gets thrown. However, since I didn't need those plots, I simply catch the error if it occurs and skip the drawing - this could maybe be made into an issue.shift_in_samples
insynchronizer
to add1
instead off subtracting it, the reference signal became much better synced, even without MSCL's fix7*128=896
per second per sensor for me)