Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Upgrade phosphor to V3 #4284

Merged
merged 1 commit into from
Nov 11, 2024
Merged

feat: Upgrade phosphor to V3 #4284

merged 1 commit into from
Nov 11, 2024

Conversation

GordonSmith
Copy link
Member

@GordonSmith GordonSmith commented Nov 9, 2024 •
edited
Loading

Checklist:

  • The commit message is properly formatted and free of typos.
    • The commit message title makes sense in a changelog, by itself.
    • The commit message includes a "fixes" reference if appropriate.
    • The commit is signed.
  • The change has been fully tested:
    • I have viewed all related gallery items
    • I have viewed all related dermatology items
  • There are no similar instances of the same problem that should be addressed
    • I have addressed them here
    • I have raised new issues to address them separately

Testing:

@GordonSmith GordonSmith requested a review from jeclrsg November 9, 2024 10:03
jeclrsg
jeclrsg reviewed Nov 11, 2024
View reviewed changes
Copy link
Contributor

@jeclrsg jeclrsg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GordonSmith only thing I noticed was one of the imports in the spec file looked wrong

packages/phosphor/tests/phosphor.browser.spec.ts Outdated
@@ -0,0 +1,39 @@
import * as codemirror from "@hpcc-js/phosphor";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this import wrong?

@GordonSmith
feat: Upgrade phosphor to V3
61a2134 
Signed-off-by: Gordon Smith <[email protected]>
@GordonSmith GordonSmith merged commit c6496af into hpcc-systems:candidate-3.x.x Nov 11, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeclrsg jeclrsg jeclrsg left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GordonSmith @jeclrsg