Merge pull request #4337 from GordonSmith/GRAPH_NODE_ISSUE

fix: Prevent React from being included in the bundle
hpcc-systems · Jan 31, 2025 · b132c33 · b132c33
2 parents 2207041 + 280db7a
commit b132c33
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 3 deletions.
diff --git a/packages/graph/package.json b/packages/graph/package.json
@@ -44,6 +44,9 @@
         "@hpcc-js/react": "^3.2.1",
         "@hpcc-js/util": "^3.3.0"
     },
+    "optionalPeerDependencies": {
+        "react": ">=18.0.0"
+    },
     "devDependencies": {
         "@hpcc-js/esbuild-plugins": "^1.4.0",
         "@hpcc-js/wasm-graphviz": "1.6.1",
@@ -59,7 +62,6 @@
         "dagre": "0.8.5",
         "lit-html": "3.2.1"
     },
-    "peerDependencies": {},
     "repository": {
         "type": "git",
         "url": "git+https://github.com/hpcc-systems/Visualization.git"

diff --git a/packages/graph/tsconfig.json b/packages/graph/tsconfig.json
@@ -7,7 +7,7 @@
         "emitDeclarationOnly": true,
         "declaration": true,
         "declarationDir": "types",
-        "jsx": "react-jsx",
+        "jsx": "react",
         "strict": true,
         "noImplicitAny": false,
         "strictNullChecks": false,

diff --git a/packages/graph/vite.config.ts b/packages/graph/vite.config.ts
@@ -14,7 +14,7 @@ export default defineConfig({
             fileName: "index",
         },
         rollupOptions: {
-            external,
+            external: [...external, "react", "react-dom"],
             output: {
                 globals,
             },