Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ISO-8601 date format #28

Merged
merged 1 commit into from
Feb 11, 2025

Conversation

hainest
Copy link
Contributor

@hainest hainest commented Feb 8, 2025

I couldn't find official documentation, but all resources point to this SO post:
https://stackoverflow.com/questions/30933741/jekyll-cant-sort-collection-by-date

Corrected version of #26.

@vsoch I updated the import date format to match the one used in the Google sheet (d/m/yyyy). Is it safe for me to test the importer locally?

@vsoch
Copy link
Contributor

vsoch commented Feb 8, 2025

It should be OK to run locally - the Google sheet that is used for the update is grabbed progammatically via a csv url from Google sheets. What you might want to do is make a copy of the current _data/jobs.yaml in case you want to restore or redo tests. Although the script (if I remember) will generate a previous jobs file in the same directory. The update will write to tmp and then use that file to replace the current jobs, so it will update.

@hainest hainest force-pushed the thaines/update_date_handling branch from 145b212 to 6a49727 Compare February 11, 2025 21:56
I couldn't find official documentation, but all resources point to this SO post:
https://stackoverflow.com/questions/30933741/jekyll-cant-sort-collection-by-date
@hainest hainest force-pushed the thaines/update_date_handling branch from 6a49727 to b9b95d5 Compare February 11, 2025 22:36
@hainest
Copy link
Contributor Author

hainest commented Feb 11, 2025

@vsoch I was able to successfully run scripts/update_jobs.py against ec5fcd3.

@vsoch
Copy link
Contributor

vsoch commented Feb 11, 2025

Woot! OK Let's go in for round 2 then.. LEEEEROOOOY.... JAAAAEEENKINS!

@vsoch vsoch merged commit 8324d86 into hpc-social:main Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants