fix: Resolve issues with timeouts and target closures in test framework #981
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Increase Playwright browser context timeouts, adjust Web Test Runner configuration for graceful timeout handling, and review test scripts for proper error handling and interactions. This commit addresses issues related to timeouts and target closures in our test framework. It includes improvements to handle timeouts more effectively and prevent unexpected target closures during test execution. - Playwright browser contexts now have increased timeout settings. - Web Test Runner configuration has been adjusted to handle timeouts gracefully. - Test scripts have been reviewed for proper error handling and interactions. This commit ensures the reliability and stability of our automated tests.
|
Thanks @AfolabiOlaoluwa |
shiftyp
pushed a commit
to shiftyp/ts-turbo
that referenced
this pull request
Sep 8, 2023
…ixes fix: Resolve issues with timeouts and target closures in test framework
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces a couple of important updates to our project's configuration files to address specific issues and improve the reliability of our testing and browser automation setup.
This commit addresses issues related to timeouts and target closures in our test framework. It includes improvements to handle timeouts more effectively and prevent unexpected target closures during test execution.
This commit ensures the reliability and stability of our automated tests. Running
yarn testnow perfectly processtest:unit && yarn test:browsereffectively and proceeds to playwright test without any hassle.Reason for Changes
The changes were made to address timeout issues encountered when running tests, specifically in Firefox. By extending the browser start timeout, we ensure that the browser has sufficient time to initialize and start the test page, reducing the likelihood of test failures due to timeouts.
These adjustments aim to improve the overall stability and reliability of our testing environment, making it more robust when running tests across different browsers.
Console Output Image