Replace Location class with browser-provided URL

[seanpdoyle]

The Turbo-internal Location class' responsibilities overlap almost
entirely with the browser-provided URL class. In addition, Turbo's
Location class name conflicts with the browser-provided Location
class, which is itself an almost URL-compliant interface.

This commit removes the Turbo-internal Location class, and modifies
all consuming interfaces to use URL instead.

The properties and functions that do not have corresponding
URL-provided versions have been extracted to the src/core/url.ts
module.

[Intrepidd]

👍 I was about to open a ticket to ask to export it as it is needed by navigator.history.push which is exported, this is even better, thanks !

[sstephenson]

Cheers to modernization! 🎉

[ghiculescu]

Hey, I think there is a bug in how forms are submitted since this PR was merged. Basically, all the elements of a form are being included in the URL when it's submitted.

This is what form submissions look like with the latest Turbo from npm:

If you clone the repo and then point your package.json at your clone on the main branch, they look like this:

If you do git checkout 178c817dc75d9559b3b624058f28a5bbf466a841 then run against that, the bug is gone:

This line seems to be the culprit: https://github.com/hotwired/turbo/pull/90/files#diff-68b647dc2963716dc27c070f261d0b942ee9c00be7c4149ecb3a5acd94842d40R53

It looks like it is replacing the old behavior here, but that behavior only ran on GET requests. Now it runs on every request.

[seanpdoyle]

@ghiculescu thanks for reporting this! I believe the decision was deliberate, but #128 might handle the nuance a little more appropriately.

[ghiculescu]

I don't think putting the contents of the form body in the URL are a good idea. As an example of why, different browsers implement different rules around URL lengths which this could now break. There's probably also security implications, eg. if your server logs URLs but not request bodies, it may suddenly start logging passwords or authenticity tokens (like my 2nd screenshot).

[ghiculescu]

ba323e4 looks like it'll fix it. Thanks @seanpdoyle