CI: Restore passing tests #725
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the reverting of [hotwired#569][] (merged as [hotwired#723][]), the "Visit with network error" test coverage was missed in the diff. Prior to the revert, the test was listening for `turbo:fetch-request-error` events dispatched on the _link_ that was clicked. Since that's no longer the case, this commit changes the test to listen for `turbo:fetch-request-error` that bubble up to the document. [hotwired#569]: hotwired#569 [hotwired#723]: hotwired#723
seanpdoyle
force-pushed
the
pass-fetch-error-tests
branch
from
20ae5b5 to
0e5db41
Compare
|
Thanks @seanpdoyle, I missed that one. There is quite a lot of flakiness in the tests currently! Just to clarify, this was actually from the revert of #695 I think, rather than #569? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the reverting of hotwired/turbo#695 (merged as hotwired/turbo#723), the "Visit with network error" test coverage was missed in the diff.
Prior to the revert, the test was listening for
turbo:fetch-request-errorevents dispatched on the link that was clicked. Since that's no longer the case, this commit changes the test to listen forturbo:fetch-request-errorthat bubble up to the document.