Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export Custom Elements and Stream Action Types #708

Merged
merged 3 commits into from
Sep 12, 2022

Conversation

marcoroth
Copy link
Member

@marcoroth marcoroth commented Sep 6, 2022

When working with TypeScript in applications and libraries in can be quite frustrating to get the right types, especially when a library doesn't export all the required types.

Therefore this Pull Request exports the types and classes for the Custom Elements and Stream Actions so they can be used in applications and libraries without the need to redefine the types manually.

I also re-organized to exports for the http subfolder, since those types were exported from the core subfolder, which technically shouldn't need to care about the exports of other subfolders.

@dhh dhh merged commit 09d0bb1 into hotwired:main Sep 12, 2022
@marcoroth marcoroth deleted the export-elements-and-types branch September 12, 2022 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants