Progress Bar Won't Render if CSP is Turned On #501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seanpdoyle
added a commit
to seanpdoyle/turbo
that referenced
this pull request
Feb 13, 2022
Merging [hotwired#501][] into `main` introduced a [consistent failure to the test suite][ci-failure]: ``` × firefox on linux 5.11.0-1022-azure - RenderingTests - progress bar inline style has nonce (0.32s) 458 AssertionError: displays progress bar: expected false to be truthy 459 at RenderingTests.test progress bar inline style has nonce @ src/tests/functional/rendering_tests.ts:24:16 460 at processTicksAndRejections @ internal/process/task_queues.js:97:5 461 at async RenderingTests.runTest @ src/tests/helpers/intern_test_case.ts:43:6 ``` This commit re-structures the test to make the same assertion (replacing the [script][] tagname with [style][]). [script]: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/script [style]: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/style [ci-failure]: https://github.com/hotwired/turbo/runs/4574673552?check_suite_focus=true#step:7:457 [hotwired#501]: hotwired#501
seanpdoyle
added a commit
to seanpdoyle/turbo
that referenced
this pull request
Feb 13, 2022
Merging [hotwired#501][] into `main` introduced a [consistent failure to the test suite][ci-failure]: ``` × firefox on linux 5.11.0-1022-azure - RenderingTests - progress bar inline style has nonce (0.32s) 458 AssertionError: displays progress bar: expected false to be truthy 459 at RenderingTests.test progress bar inline style has nonce @ src/tests/functional/rendering_tests.ts:24:16 460 at processTicksAndRejections @ internal/process/task_queues.js:97:5 461 at async RenderingTests.runTest @ src/tests/helpers/intern_test_case.ts:43:6 ``` This commit re-structures the test to make the same assertion (replacing the [script][] tagname with [style][]). [script]: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/script [style]: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/style [ci-failure]: https://github.com/hotwired/turbo/runs/4574673552?check_suite_focus=true#step:7:457 [hotwired#501]: hotwired#501
dhh
pushed a commit
that referenced
this pull request
Mar 30, 2022
Merging [#501][] into `main` introduced a [consistent failure to the test suite][ci-failure]: ``` × firefox on linux 5.11.0-1022-azure - RenderingTests - progress bar inline style has nonce (0.32s) 458 AssertionError: displays progress bar: expected false to be truthy 459 at RenderingTests.test progress bar inline style has nonce @ src/tests/functional/rendering_tests.ts:24:16 460 at processTicksAndRejections @ internal/process/task_queues.js:97:5 461 at async RenderingTests.runTest @ src/tests/helpers/intern_test_case.ts:43:6 ``` This commit re-structures the test to make the same assertion (replacing the [script][] tagname with [style][]). [script]: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/script [style]: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/style [ci-failure]: https://github.com/hotwired/turbo/runs/4574673552?check_suite_focus=true#step:7:457 [#501]: #501
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Progress Bar injects inline
<style />element to page. However, when Content Security Policy is turned on andnonceis generated - Progress Bar element ignores that.This PR fixes that and checks if
csp-nonceis set inmetatags. Then it uses it to create inline style.Update: I don't know why test is failing and is generating
<style />withoutnoncebeing set. However, when testing manually - this fix works. I might need some help here from someone more experienced in writing JS tests.