Toggle [aria-busy] instead of [busy] #157
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javan
approved these changes
Feb 4, 2021
src/core/frames/frame_controller.ts
Outdated
| } | ||
|
|
||
| // Form submission delegate | ||
|
|
||
| formSubmissionStarted(formSubmission: FormSubmission) { | ||
|
|
||
| const frame = this.findFrameElement(formSubmission.formElement) | ||
| if (frame) { |
There was a problem hiding this comment.
Is frame ever not present? Looks like it falls back to this.element:
turbo/src/core/frames/frame_controller.ts
Lines 220 to 222 in 0c2bd14
There was a problem hiding this comment.
@javan ah, I must've missed this while splitting out the separate [aria-busy] PR from the original: https://github.com/hotwired/turbo/pull/156/files#diff-8f44fafd854f6f716d51a2b05b5689266a9b66e0b1ad9d68570bd4e8cefd0a47R161
Since `<turbo-frame>` elements are custom elements, the framework has total control over the names of the attributes. There are existing semantics for what we've introduced as `[busy]`: the ARIA guidelines suggest toggling [aria-busy="true"][aria-busy] when an element is loading more content, and `aria-busy="false"` when the content is loaded. This provides an "interface" for loading styles through CSS attribute selectors, and hints to assistive technologies the state of the frame. As an alternative, we could continue to toggle the `[busy]` attribute, and encourage consumer applications to monitor mutations to the `[busy]` attribute (or listen to [`turbo:frame-visit` and `turbo:frame-load` events][events]) to toggle it themselves. [aria-busy]: https://www.w3.org/TR/wai-aria-1.1/#aria-busy [events]: hotwired#59
seanpdoyle
force-pushed
the
frame-aria-busy
branch
from
0c2bd14 to
bc569dc
Compare
seanpdoyle
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since
<turbo-frame>elements are custom elements, the framework hastotal control over the names of the attributes.
There are existing semantics for what we've introduced as
[busy]: theARIA guidelines suggest toggling aria-busy="true" when an
element is loading more content, and
aria-busy="false"when thecontent is loaded.
This provides an "interface" for loading styles through CSS attribute
selectors, and hints to assistive technologies the state of the frame.
As an alternative, we could continue to toggle the
[busy]attribute,and encourage consumer applications to monitor mutations to the
[busy]attribute (or listen to
turbo:frame-visitandturbo:frame-loadevents) to toggle it themselves.