Restore correct Accept header for form submissions #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes #141. Follows-up #52. --- When creating the headers for a `FetchRequest`, provide the default headers to the delegate by adding an argument to the `additionalHeadersForRequest` signature so that delegates can incorporate the current values if they choose to. They're passed as a copy to prevent delegates from destructively acting upon them, with the intention that delegates merge values _into_ them. Testing --- Add a guard middleware to the test server to reject _all_ requests that don't specify an [Accept][] header containing `"text/html, application/xhtml+xml"`. Next, guard Stream requests with a similar check for `"text/vnd.turbo-stream.html"`. Since those endpoints are behind the guard middleware, they'll also require `"text/html, application/xhtml+xml"` as well. Finally, replace the Stream functional test's explicit call to `fetch` with a `<form>` element submitting with the same content. [Accept]: https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Accept
sstephenson
force-pushed
the
html-header
branch
from
0d6277b to
7d98260
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #141.
Follows-up #52.
When creating the headers for a
FetchRequest, provide the defaultheaders to the delegate by adding an argument to the
additionalHeadersForRequestsignature so that delegates canincorporate the current values if they choose to. They're passed as a
copy to prevent delegates from destructively acting upon them, with the
intention that delegates merge values into them.
Testing
Add a guard middleware to the test server to reject all requests that
don't specify an Accept header containing
"text/html, application/xhtml+xml".Next, guard Stream requests with a similar check for
"text/vnd.turbo-stream.html". Since those endpoints are behind theguard middleware, they'll also require
"text/html, application/xhtml+xml"as well.Finally, replace the Stream functional test's explicit call to
fetchwith a
<form>element submitting with the same content.