Frames are caching too late

[manuelpuyol]

Kinda related to #643

When doing a frame navigation, the frame src changes before the page is cached, causing some weird interactions when going back/forwards.

Example

Frames with data-turbo-action="advance"

Screen.Recording.2022-09-28.at.2.27.41.PM.mov

[manuelpuyol]

@seanpdoyle it looks like when the frame is promoted with advance, we start a visit after the frame is already loaded, so the PageView snapshot cache is running with the new HTML instead of the original one

[seanpdoyle]

@manuelpuyol thank you for opening this issue and providing instructions on how to reproduce.

I've pushed up a breaking test to https://github.com/hotwired/turbo/compare/seanpdoyle:fix-issue-745, and am investigating a resolution.

[manuelpuyol]

Thanks for looking into this @seanpdoyle !

I opened a possible solution here #746, gonna pull in your tests to check if they pass