data-turbo-action="advance" doesn't update browser URL #489

wonderix · 2021-12-02T09:31:54Z

The documentation says that the browser URL will be updated if data-turbo-action="advance" is set on a link or a turbo frame.
Unfortunately, only the src attribute of the turbo frame is updated.
When using Turbo.visit(), the src attribute and the browser url are updated.

I'm using version 7.0.1.

Is this related to #468?

The text was updated successfully, but these errors were encountered:

dhh · 2021-12-02T10:11:06Z

That feature was included in 7.1.0: https://github.com/hotwired/turbo/releases/tag/v7.1.0

luglio7 · 2022-01-31T12:33:52Z

when i manually update the src attribute of a frame with "data-turbo-action" set to "advance" the url doesn't change. I'm missing something ? When i click a link inside a frame everything is working as expected.

leoplct · 2022-07-07T18:05:07Z

Solved changing package.json to "@hotwired/turbo-rails": "^7.1.0" and run yarn upgrade turbo

walterhorstman · 2022-07-29T07:36:34Z

Are we sure this is working? I'm creating a fresh Rails 7 application, have included stimulus-rails and turbo-rails in Gemfile and package.json contains "@hotwired/turbo-rails": "latest" under "dependencies". yarn.lock indicates I'm using 7.1.3 of @hotwired/turbo.

My view contains <turbo-frame data-turbo-action="advance" id="header" target="main"><a href="..."></a></turbo-frame> and further a <turbo-frame id="main"></turbo-frame>. I would expect the page's URL to change when clicking the link.

dmitrue · 2023-03-20T07:30:28Z

Same for me, I'm using "@hotwired/turbo-rails": "^7.3.0", and Turbo.visit('/...', { frame: 'results', action: 'advance' }) doesn't update URL of the page

cmalven · 2023-03-27T20:52:36Z

May or not be related, but I'm experiencing a similar issue even without manually setting action: 'advance':

    Turbo.visit(url, {
      frame: 'my-frame',
    });

Updates the src attribute on the frame but does not update the URL. "@hotwired/turbo": "^7.3.0"

perlun · 2023-04-11T10:11:10Z

For me, with Turbo 7.1.0, I see that it's working when navigating to other content within a turbo frame. When trying to combine it with target="content" (similar to in your example @walterhorstman), it refuses to update the URL. 🤔

I'll try updating to 7.3.0 to see if I can reproduce it there as well.

Update: the problem persists with 7.3.0. Also, the "working" part above seems irregular to me:

If you first navigate using a target="foo" link, the history/URL is not updated.
If you then navigate "inside" a frame, it still won't update the history.

However, if you do like this:

Reload the browser window.
Navigate inside a frame

...it works as intended for me; history and URL is updated as it should be.

perlun · 2023-04-11T10:30:14Z

@seanpdoyle - this is of course a bit premature, but it feels like this could be a limitation in the initial implementation in #398. 🤔 Would you like an isolated test case or could you give it a look regardless?

To make things reasonably clear, we're talking about scenarios like this:

<body>
  <turbo-frame id="nav" target="content" data-turbo-action="advance">
    <!-- Links inside this frame are broken; the data-turbo-action properly is not properly honored -->
    <a href="/link-one">Link one</a>
    <a href="/link-two">Link two</a>
  </turbo-frame>

  <turbo-frame id="content" data-turbo-action="advance">
    <!-- Links inside this frame works correctly re. URL/history, with the limitations described in
         earlier comment -->
    <a href="/link-three">Link three</a>
  </turbo-frame>
</body>

bopm · 2023-04-21T15:36:10Z

After debugging it, I am seeing that this.action here is null no matter Turbo.visit configuration.

bopm · 2023-04-21T15:59:43Z

I suspect this issue was introduced here, as before this change options were taken into account, but not any longer after that change. And Turbo.visit lands here.
cc @seanpdoyle

louiswdavis · 2023-05-24T15:21:42Z

As a workaround, I added a controller to my rendered html that when connected passes values for the page name and path I want to set

 <div data-controller="url" data-url-page-value="Page Name" data-url-path-value="/appended_path"></div>

export default class extends Controller {
  static values = {
    page: String,
    path: String,
  }

  connect() {
    window.history.replaceState(window.history.state, this.pageValue, this.pathValue)
  }
}

jtreitz · 2023-06-08T15:22:34Z

I'd expect the following to update my URL but it doesn't :(
Turbo.visit(url, { frame: 'a', action: 'advance' })

bopm · 2023-06-09T17:24:56Z

@dhh @seanpdoyle this issue is regressed since 7.3.0, can we get this issue back open?

leonvogt · 2023-11-28T08:41:35Z

I'd expect the following to update my URL but it doesn't :(
Turbo.visit(url, { frame: 'a', action: 'advance' })

Same. Would be really nice if that worked.

jasonswett · 2024-01-18T02:03:26Z

I had this issue and upgrading to Rails 7.1.3 and Turbo 1.5 seemed to fix it for me. (I don't know which upgrade was responsible for the fix.)

Closes [hotwired#489][] First, add test coverage to exercise the `<turbo-frame id="frame">` and `<turbo-frame id="hello" target="frame">` as outlined in a [comment on hotwired#489][]. Next, add coverage to support driving a `<turbo-frame data-turbo-action="advance">` through the `Turbo.visit` method. To pass that test coverage, invoke `frameElement.delegate.proposeVisitIfNavigatedWithAction(frameElement)` prior to modifying the element's `[src]` attribute. [hotwired#489]: hotwired#489 [comment on hotwired#489]: hotwired#489 (comment)

seanpdoyle · 2024-01-22T15:31:49Z

May or not be related, but I'm experiencing a similar issue even without manually setting action: 'advance':
    Turbo.visit(url, {
      frame: 'my-frame',
    });
Updates the src attribute on the frame but does not update the URL. "@hotwired/turbo": "^7.3.0"

I've opened #1135 to resolve this issue.

seanpdoyle · 2024-01-22T15:32:54Z

@seanpdoyle - this is of course a bit premature, but it feels like this could be a limitation in the initial implementation in #398. 🤔 Would you like an isolated test case or could you give it a look regardless?

To make things reasonably clear, we're talking about scenarios like this:
<body>
  <turbo-frame id="nav" target="content" data-turbo-action="advance">
    
    <a href="/link-one">Link one</a>
    <a href="/link-two">Link two</a>
  </turbo-frame>

  <turbo-frame id="content" data-turbo-action="advance">
    
    <a href="/link-three">Link three</a>
  </turbo-frame>
</body>

I've added test coverage to #1135 to attempt to resolve this issue. Unfortunately, I was able to pass the test without any implementation changes. Could you review that diff (mainly https://github.com/hotwired/turbo/pull/1135/files#diff-1e84a1526802b27615a24efc0f9b75c27b2a9197d855a8ccc5475db14609ed6f and https://github.com/hotwired/turbo/pull/1135/files#diff-4706705ec52e666c36d3cd9410d3aad96354c69f61a18f880b40291836485f36R655-R663 to help me reproduce the underlying issue more closely?

Closes [hotwired#489][] First, add test coverage to exercise the `<turbo-frame id="frame">` and `<turbo-frame id="hello" target="frame">` as outlined in a [comment on hotwired#489][]. Next, add coverage to support driving a `<turbo-frame data-turbo-action="advance">` through the `Turbo.visit` method. To pass that test coverage, invoke `frameElement.delegate.proposeVisitIfNavigatedWithAction(frameElement)` prior to modifying the element's `[src]` attribute. To support the implementation changes necessary to pass the tests, this commit makes one change to the public interface, and another to an internal interface. * `FrameElement.getElementById(id: string)` - unify the process to internally resolve a `<turbo-frame>` element by its `[id]`. Update call sites to use this new method * `FrameController.proposeVisitIfNavigatedWithAction(frame, elements = [], options = {})` - flatten the variable arguments into a single `Array`, then extend the interface to support Visit options like `{ action: }` [hotwired#489]: hotwired#489 [comment on hotwired#489]: hotwired#489 (comment)

Closes [hotwired#489][] First, add test coverage to exercise the `<turbo-frame id="frame">` and `<turbo-frame id="hello" target="frame">` as outlined in a [comment on hotwired#489][]. Next, add coverage to support driving a `<turbo-frame data-turbo-action="advance">` through the `Turbo.visit` method. To pass that test coverage, invoke `frameElement.delegate.proposeVisitIfNavigatedWithAction(frameElement)` prior to modifying the element's `[src]` attribute. To support the implementation changes necessary to pass the tests, this commit makes one change to the public interface, and another to an internal interface. * `FrameElement.getElementById(id: string)` - unify the process to internally resolve a `<turbo-frame>` element by its `[id]`. Update call sites to use this new method * `FrameController.proposeVisitIfNavigatedWithAction(frame, action)` - flatten the variable arguments into a single `action` argument. Move the `getVisitAction` call to the call sites that require it, and pass in the `action` directly when its available [hotwired#489]: hotwired#489 [comment on hotwired#489]: hotwired#489 (comment)

Closes [hotwired#489][] Closes [hotwired#468][] First, add test coverage to exercise the `<turbo-frame id="frame">` and `<turbo-frame id="hello" target="frame">` as outlined in a [comment on hotwired#489][]. Next, add coverage to support driving a `<turbo-frame data-turbo-action="advance">` through the `Turbo.visit` method. To pass that test coverage, invoke `frameElement.delegate.proposeVisitIfNavigatedWithAction(frameElement)` prior to modifying the element's `[src]` attribute. To support the implementation changes necessary to pass the tests, this commit makes one change to the public interface, and another to an internal interface. * `FrameElement.getElementById(id: string)` - unify the process to internally resolve a `<turbo-frame>` element by its `[id]`. Update call sites to use this new method * `FrameController.proposeVisitIfNavigatedWithAction(frame, action)` - flatten the variable arguments into a single `action` argument. Move the `getVisitAction` call to the call sites that require it, and pass in the `action` directly when its available [hotwired#489]: hotwired#489 [hotwired#468]: hotwired#468 [comment on hotwired#489]: hotwired#489 (comment)

Closes [hotwired#489][] Closes [hotwired#468][] First, add test coverage to exercise the `<turbo-frame id="frame">` and `<turbo-frame id="hello" target="frame">` as outlined in a [comment on hotwired#489][]. Next, add coverage to support driving a `<turbo-frame data-turbo-action="advance">` through the `Turbo.visit` method. To pass that test coverage, invoke `frameElement.delegate.proposeVisitIfNavigatedWithAction(frameElement)` prior to modifying the element's `[src]` attribute. To support the implementation changes necessary to pass the tests, this commit changes the `proposeVisitIfNavigatedWithAction(frame, action)` interface by flattening the variable arguments into a single `action` argument, then moving the `getVisitAction` call to the call sites that require it. The call sites that know their `action` pass it in directly when its available. [hotwired#489]: hotwired#489 [hotwired#468]: hotwired#468 [comment on hotwired#489]: hotwired#489 (comment)

Closes [#489][] Closes [#468][] First, add test coverage to exercise the `<turbo-frame id="frame">` and `<turbo-frame id="hello" target="frame">` as outlined in a [comment on #489][]. Next, add coverage to support driving a `<turbo-frame data-turbo-action="advance">` through the `Turbo.visit` method. To pass that test coverage, invoke `frameElement.delegate.proposeVisitIfNavigatedWithAction(frameElement)` prior to modifying the element's `[src]` attribute. To support the implementation changes necessary to pass the tests, this commit changes the `proposeVisitIfNavigatedWithAction(frame, action)` interface by flattening the variable arguments into a single `action` argument, then moving the `getVisitAction` call to the call sites that require it. The call sites that know their `action` pass it in directly when its available. [#489]: #489 [#468]: #468 [comment on #489]: #489 (comment)

dhh closed this as completed Dec 2, 2021

dhh reopened this Jun 18, 2023

seanpdoyle mentioned this issue Jan 22, 2024

Drive turbo-frame with Turbo.visit(url, { frame:, action: }) #1135

Merged

seanpdoyle mentioned this issue Jan 30, 2024

Do not invalidate pages in visits that don't render #1144

Merged

afcapel closed this as completed in #1135 Feb 2, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

data-turbo-action="advance" doesn't update browser URL #489

data-turbo-action="advance" doesn't update browser URL #489

wonderix commented Dec 2, 2021

dhh commented Dec 2, 2021

luglio7 commented Jan 31, 2022

leoplct commented Jul 7, 2022 •

edited

Loading

walterhorstman commented Jul 29, 2022

dmitrue commented Mar 20, 2023

cmalven commented Mar 27, 2023

perlun commented Apr 11, 2023 •

edited

Loading

perlun commented Apr 11, 2023 •

edited

Loading

bopm commented Apr 21, 2023 •

edited

Loading

bopm commented Apr 21, 2023

louiswdavis commented May 24, 2023 •

edited

Loading

jtreitz commented Jun 8, 2023

bopm commented Jun 9, 2023

leonvogt commented Nov 28, 2023

jasonswett commented Jan 18, 2024

seanpdoyle commented Jan 22, 2024

seanpdoyle commented Jan 22, 2024

data-turbo-action="advance" doesn't update browser URL #489

data-turbo-action="advance" doesn't update browser URL #489

Comments

wonderix commented Dec 2, 2021

dhh commented Dec 2, 2021

luglio7 commented Jan 31, 2022

leoplct commented Jul 7, 2022 • edited Loading

walterhorstman commented Jul 29, 2022

dmitrue commented Mar 20, 2023

cmalven commented Mar 27, 2023

perlun commented Apr 11, 2023 • edited Loading

perlun commented Apr 11, 2023 • edited Loading

bopm commented Apr 21, 2023 • edited Loading

bopm commented Apr 21, 2023

louiswdavis commented May 24, 2023 • edited Loading

jtreitz commented Jun 8, 2023

bopm commented Jun 9, 2023

leonvogt commented Nov 28, 2023

jasonswett commented Jan 18, 2024

seanpdoyle commented Jan 22, 2024

seanpdoyle commented Jan 22, 2024

leoplct commented Jul 7, 2022 •

edited

Loading

perlun commented Apr 11, 2023 •

edited

Loading

perlun commented Apr 11, 2023 •

edited

Loading

bopm commented Apr 21, 2023 •

edited

Loading

louiswdavis commented May 24, 2023 •

edited

Loading