Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document turbo:before-{,frame,stream}-render events #126

Merged
merged 1 commit into from
Dec 31, 2022

Conversation

seanpdoyle
Copy link
Contributor

Documents hotwired/turbo#431
Documents hotwired/turbo#684

Share examples for turbo:before-render, turbo:before-frame-render, and turbo:before-stream-render events that override the event.detail.render function.

Additionally, document pausable rendering for <turbo-frame> elements.

@@ -186,6 +186,40 @@ Turbo Streams consciously restricts you to seven actions: append, prepend, (inse

Embracing these constraints will keep you from turning individual responses in a jumble of behaviors that cannot be reused and which make the app hard to follow. The key benefit from Turbo Streams is the ability to reuse templates for initial rendering of a page through all subsequent updates.

## Custom Actions
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@marcoroth I'd appreciate reviewing on these documentation improvements.

If you only review one section, I'd love for it to be the Custom Actions one!

@seanpdoyle seanpdoyle force-pushed the document-custom-rendering branch from adb1c49 to 0317003 Compare December 29, 2022 02:18
Documents [hotwired/turbo#431][]
Documents [hotwired/turbo#684][]

Share examples for `turbo:before-render`, `turbo:before-frame-render`,
and `turbo:before-stream-render` events that override the
`event.detail.render` function.

Additionally, document pausable rendering for `<turbo-frame>` elements.

[hotwired/turbo#431]: hotwired/turbo#431
[hotwired/turbo#684]: hotwired/turbo#684
@seanpdoyle seanpdoyle force-pushed the document-custom-rendering branch from 0317003 to 4231925 Compare December 29, 2022 02:23
@dhh dhh merged commit 92c905d into hotwired:main Dec 31, 2022
@seanpdoyle seanpdoyle deleted the document-custom-rendering branch December 31, 2022 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants