Make target
and targets
attributes optional for Stream actions
#375
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the introduction of Custom Stream Actions we can now create Stream Actions that not necessarily require a
target
attribute to be present.In order to keep the behaviour we need to raise anArgumentError
if notarget
was passed to a default stream action helper.This Pull Request adds a constant with the default actions which require atarget
ortargets
attribute to be present. For any other action it will return a regular<turbo-stream>
tag without thetarget
attribute.Edit: This Pull Request removes the check and thus makes the
target
andtargets
attributes optional for stream actions.Related: #373 and #374