Implemented: show order cards horizontally based on order ship group/part (#85zrv9fhc) #225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… group (#85zrv9fhc)
… for order parts (#85zrv9fhc)
…ter cursor for open order cards (#85zrv9fhc)
alsoK2maan
changed the title
adityasharma7
suggested changes
Apr 10, 2023
src/views/Orders.vue
Outdated
| @@ -22,8 +22,8 @@ | |||
| </ion-header> | |||
| <ion-content> | |||
| <div v-if="segmentSelected === 'open'"> | |||
| <div v-for="order in orders" :key="order.orderId" v-show="order.parts.length > 0"> | |||
| <ion-card v-for="(part, index) in order.parts" :key="index" @click.prevent="viewOrder(order, part)"> | |||
| <div v-for="order in openOrdersByPart" :key="order.orderId" v-show="order.parts.length > 0"> | |||
There was a problem hiding this comment.
orderId might not be unique now
Suggested change
| <div v-for="order in openOrdersByPart" :key="order.orderId" v-show="order.parts.length > 0"> | |
| <div v-for="order in openOrdersByPart" :key="index" v-show="order.parts.length > 0"> |
src/views/Orders.vue
Outdated
| </ion-button> | ||
| </div> | ||
| </ion-card> | ||
| </div> | ||
| </div> | ||
| <div v-if="segmentSelected === 'packed'"> | ||
| <div v-for="order in packedOrders" :key="order.orderId" v-show="order.parts.length > 0"> | ||
| <ion-card v-for="(part, index) in order.parts" :key="index"> | ||
| <div v-for="order in packedOrdersByPart" :key="order.orderId" v-show="order.parts.length > 0"> |
There was a problem hiding this comment.
We could directly call getOrdersByPart() here and pass orders
adityasharma7
approved these changes
Apr 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Closes #222
Short Description and Why It's Useful
Implemented rendering of packed orders based on ship group (order parts) in the UI.
This fixed the issue of duplicate cards showing up vertically in the UI for orders having different ship groups.
Screenshots of Visual Changes before/after (If There Are Any)
Before -
After -
Contribution and Currently Important Rules Acceptance