-
-
Notifications
You must be signed in to change notification settings - Fork 278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revisit Task Colors #1257
Comments
Thanks @russdeffner for bringing that up. One quick question: does an invalidated task even need to be colored? I can see the case for a project manager or validator to maybe know, but for a mapper it doesn't make a difference right? |
I think there is value in having some noticeable difference in a task that is invalidated - i.e. a bit of warning that it might be fixing stuff rather than just drawing new features. |
Probably related to this: #1523. |
I am a big fan of icons 👍 we've struggled for a while with all the different colors. I tried to add pin-striping in TM2 to indicate a checked out task, but ran into issues with the map library at that point. An icon might be a way to indicate the status in a manner different than colors without being too overbearing. Furthermore, being able to see at a glance what state of task someone has checked out (e.g. mapping versus validating) could be beneficial. |
I have the implementation for OpenLayers if you want to implement icons soon. But as @xamanu mentions in #1541 we may be switching from OL soon. If that's the case, it may be better to make the switch for the map library before adding icons. From what I've seen, not many people are making changes that rely heavily on the map so switching the map library might be safer than changing the whole front end framework. Thoughts @xamanu? |
On the colors, we got some input from our redesign. Instead of adding more colors we were encouraged to reduce the states to what matters to the users: What do you think about these states and colors? I like the idea of using icons for further indication, like user to tasks assignments in #1575. And i guess we will have more good use for this for future features. |
@xamanu I believe the comments about "what matters to the users" were from me on the redesign wireframes. Just to add some additonal context. In the screenshot you shared above, I think the most important things should be I would argue that |
Let's compare concretely:
Some inputs:
I gave it a try to combine what I think are the best elements of each proposals based on our conversations:
This proposal is not shorting the list of seven elements. But hopefully it is more consolidated and combining many good thoughts and improvements in itself. |
@xamanu if icons are going to be part of the redesign, I think the |
I want to bring into the conversation also this comment from @giblet22 in #1004 regarding another layer - the priority area:
And the request to take into consideration colour blindness (#608):
I'm going to close the other issues, so we can concentrate conversation here. |
Beware of the red and green colors used for "review needed" (or invalidated) and "ready". But for accessibility (by color bling people), the most problematic distinctions are always somewhere ion the middle on red and green (both are usually distinguished if they are "pure" enough, i.e. with a large enough "angle" of the hue component of colors, in HSL representation), and they are in the subtle shades of beige/brown (saturated yellow is usually disintguished because of its more important lightness than plain red, the darker, and plain green, mid-light, while yellow is much lighter). For evaluating a color scheme, please convert colors in HSL, make sure that all colors have all pairs of H differences larger than 30 degrees, and preferably larger than 60 degrees in the green-to-red sector of the color-wheel for "color blind" peoples, otherwise make sure that differences of lightness (L) are larger than 20% (you need larger difference of L if differences of hue (H) is smaller). The difference of saturation (S) does not matter and is cleared by the ~50% transparency applied, and the fact colors are then made slighly lighter. Note that about 10 to 15% of males (notably within the Caucasian/white group where it is the largest) have color blindness. It is not something to ignore. The most common group are still seeing tri-stimuli colors, but they have a perception of the green component "shifted" a bit toward the red (this is caused by a genetic mutation of the chromatic filter in retina cells). Some rare people have also this shifted component, but it comes in addition to the "normal" green component: they have both types of cells in their eyes, so their perception is quadri-stimuli, and their perception of the color gammut is larger than most people (they can distinguish thousands more distinctive colors with the same lightness and saturation; they are highly values by some companies and in arts or for exploring nature and finding interesting isolates). There are even people that have also a rare mutation of the red chromatic filter, with a second red component: they can distinguish colors even in very dark environements (where the perception of "blue" by most people is fading a lot, keeping only a vision of red-yellow/brown-green shades with the larger wavelengths: in dark environments, the tri-stimuli vision of most people becomes bi-stimuli, and mono-stimuli in very dark environements; but people with an extra red component can still preserve a tri-stimuli vision i.e. a wide gammut comparable to the vision in light environment; this extra red does not change significantly their perception of colors in light environment, except it may sometimes allow them to perceive better separation of greens and yellows/browns) And don't generalize what you find in the litterature: these are just statistic models of human vision based on averages and most often ignoring the standard deviation (caused by different relatove composition of cells from each type of chromatic filter). As well the distribution of chromatic filters is NOT uniform on the retina (so you may perceive more colors in the center of vision and less in the periphery). In conclusion: nobody sees the colors the "normal" way, everyone is unique (and the situation evolves negatively across life). That's why the HSL model is very useful, it allows evaluating that there are enough differences. The (s)RGB model here is defective (and in fact it's based on three "base" component colors that actually do not match the real colors of human chormatic filters, which are much more complex in composition than the simple ionic composition of filters used on screens; inks for printing, paintaing or drawing are much more finaly tuned, notably those based on natural components which are also very expensive and not easy to stabilize chemically across time as they are oxydated rapidly, notably the blue components, and the natural green components are oxydized towards reds; the same "oxydation" process also occurs across life in cells of animal retinas, but it is slower because it is protected or renewed by biologic mechanisms). It's in fact very easy to convert your chosen color palette to HSL and sort colors in a spreadsheet (in L, H, S order, but I bet your colors scheme will already have low differences of "L" once rendered with transparency applied, so the "H" component becomes the most important one), to evaluate the difference between successive rows: you'll see immediately if your colorscheme is accessible enough for most people (even for those rare ones that have a nearly monochromatic vision of the world). |
Yes, I agree that the HSL model will help us much more for finding the best colours. And clearly there are different types of and grades of colour vision deficiency. Over-simplifying the issue: at end it comes down to a reduced sensitivity for the spectrum of colours. And we are having quite some colours for coding the map. I don't see a real way of making all of them visual in a perfect way for a person with colour vision deficiency. However I think we can help people by thinking about grouping the layers and indicating colours to the type of users that are going to make an action on it:
So, I would try to make these three groups visual for a person with colour vision deficiency. One way of doing this is going with the brightness or lightness (L) of the colours (following the HSL model):
For assignment and locked, it might be a very good idea to go with icons. The priority area is really challenging. In the perspective of colour vision deficiency, an icon could be a solution. But then, it seem that the icons start becoming a bit overwhelming, especially when thinking about assigned and locked tasks in a priority area :) The other option could be a coloured layer in between the lightness of the others. Not sure, whether this can be confusing and persons who may have challenges differentiating it from the layer for validators ("mapped" and "review needed"). Thoughts? For all interested people, there is a browser extension to review a page (and the colours proposed here), similar like a person with different types of colour blindnesses. |
Priority Area as an icon will cause issues I think. If we show the flag, we can't show the Assigned or Locked icon which are more important because either of those restrictions determine if a user is able to take the task. I think a good option for Priority Area could be hashing the color @xamanu suggested for priority area. Hashing is a very distinguishable pattern to accomodate color deficiency. Added benefit, a yellow hashing is somewhat universal as "attention" like its use for police tape and other warning signs 🚧 |
The icons will be a good improvement, and the colors look good. |
|
Can I clarify what the "Blocked for Mapping" and "Assigned to other mapper" functionality is? |
@jbergmann91 "Blocked for Mapping" corresponds to "Bad imagery". "Assigned to other mapper" is a functionality available only in the Apple instance. Maybe we will have it on other instances in the future. |
I agree with @willemarcel's comments. And I would prefer to switch the icons, to have the human, for somebody is working on it, and the potentially new functionality using the lock, for reserved (assigned) to a user. Maybe we can also change the wording from "Review needed" to "More mapping needed". Sounds more welcoming to take on for mappers. And related to @jbergmann91 question, maybe is "blocked for mapping" also very strong. It is not really blocked, but not good for mapping, either because the imagery is bad at this place, or there might only be an area (like for example a lake or the sea) without any objects. What is a good and short wording we can use here? |
Thinking about this a little bit more radical: why do we need a colour? Can't we just exclude them from the tasks? This would be great from a user design perspective! But it has the downside that a task just disappears, after it has been marked as unmapable and can not be brought back easily. Continuing the thought.., we could bring in some approval queue for the project manager to check on tasks that have been marked unmapable to be either deleted or brought back. @hexiaok what do you think? |
instead of a so dark colouring for "blocked for mapping", I could use a
fuzzying ligh grey pattern.
Fuzzying however is not as simple to implement as a simpler alpha layer, as
it requires complx compositing support (not just 1 pixel over 1 and not so
simple to do in CSS, unless the browser has advanced support for "filters",
and otherwise it requires a modern browser support for the canvas).
An example is shown here using a "blur" filter:
https://stackoverflow.com/questions/27583937/how-can-i-make-a-css-glass-blur-effect-work-for-an-overlay
Le mer. 6 nov. 2019 à 22:39, Felix D. <[email protected]> a écrit :
… I don't like the colour of "Blocked for mapping", I think we are driving
the attention of the user to the less important tasks
Thinking about this a little bit more radical: why do we need a colour?
Can't we just exclude them from the tasks? This would be great from a user
design perspective! But it has the downside what a task marked as unmapable
disappears and can not be brought back. Continuing the thought, we could
bring in some approval queue for the project manager to check on tasks that
have been marked unmapable to be either deleted or brought back...
@hexiaok <https://github.com/hexiaok> what do you think?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#1257?email_source=notifications&email_token=AAKSUG2XGZNGSBCIEVYV4NTQSM2PPA5CNFSM4F7ROLRKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEDICM6I#issuecomment-550512249>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAKSUGZ46WSWK7SECZGZDYTQSM2PPANCNFSM4F7ROLRA>
.
|
Another option could be to make the "blocked for mapping" have half or less of the opacity of the default transparency for a task. It would seemingly disappear without actually being removed in the case of a PM needing to check and revert the status. This wouldn't add additional responsibility on the PM to check a queue to review the tasks. |
You can read more about the task assignment feature in #1575. One part of it allows PM's to manually assign tasks to individuals but it also will introduce an idea of "project ownership". If a user locks a task, it is then assigned to them whether they finish or not. Either way it is their responsibility to come back and finish the task. This is of course, a setting for the project. |
Thanks for all the feedback. Here I summarize all the comments here: 1: remove the project boundary |
After today's user group meeting the following state names have been suggested:
|
Thanks for all the input and work @hexiaok and @willemarcel. Happy to confirm that this is part of TM4 (currently in testing phase). |
This issue is to combine #1256 and #246 with a general recoloring of the task status. In the Activation Working Group we have noted that the 'red' for invalidated is maybe causing mappers to stay away from those tasks. We may also want to take into consideration color impaired vision to ensure all our mappers can easily understand what tasks are available to them.
The text was updated successfully, but these errors were encountered: