Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use logger.basicConfig for modules #244

Merged
merged 6 commits into from
Mar 24, 2024

Conversation

owolabioromidayo
Copy link
Contributor

From #207.
Prev owolabioromidayo#2

Replace logging.getLogger with logging.basicConfig for modules.
Maintain urllib logging level.
No logging configuration in the modules when args.verbose is not set.

Move arg.verbose option handling from create_basemap to main function of osm_fieldwork/basemapper.py .

Change ODKInstance.py, ODKForm.py, ODKDump.py from using log level "DEBUG" and stdout stream only when verbose not set.

@spwoodcock spwoodcock added enhancement New feature or request good first issue Issues that welcome contributions Priority: Nice to have labels Mar 23, 2024
@spwoodcock
Copy link
Member

spwoodcock commented Mar 23, 2024

Thank you 🙏

There are merge conflicts that must be solved before I can merge.

Either via:

git merge main

Or

git rebase main
(preferred, but only do this if you are comfortable rebasing)

@owolabioromidayo
Copy link
Contributor Author

I went ahead with the merge since I'm not comfortable rebasing just yet.
Tried it out but it wasn't as straightforward. More merges were required.

Hope its all good?

@spwoodcock spwoodcock merged commit 6e0367a into hotosm:main Mar 24, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Issues that welcome contributions Priority: Nice to have
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants