Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring imagery-search base map selection. #135

Closed
wants to merge 7 commits into from

Conversation

sharkinsspatial
Copy link
Collaborator

Refactoring imagery-search to support improved testability, better follow Redux best practices and adhere to Mapbox GL state management best practices closes #88.

@tombh
Copy link
Collaborator

tombh commented Jul 26, 2017

Great! Really nice coding style; clear, well thought out and nice refactoring. You clearly know your React :)

One thing that could have been good would be to have used the same testing approach as oam-browser, ie mocha and sinon (oh, actually you'd only see sinon if you looked at my unmerged branches). It's not a big deal, tape and babel-require-plugin are great too. But it would just make things easier when merging back into oam-browser. Don't feel like you have to change this though. BTW, similarly I hope that imagery-coordination-api will be merged into oam-catalog.

Anyway, looks great, nice work :)

@sharkinsspatial
Copy link
Collaborator Author

Updated .travis.yml to force use of Trusty environment rather than Precision. CI builds are now passing correctly. One additional note on updating Mapbox GL JS maps via style diffs. There is some code in this pull request that can be simplified once this upstream Mapbox GL JS issue fix is released.

@smit1678
Copy link
Collaborator

smit1678 commented Aug 1, 2017

@sharkinsspatial Feel free to assign this to me when this is ready to be reviewed and merged (we can use that method for future PRs as well).

@smit1678
Copy link
Collaborator

smit1678 commented Aug 7, 2017

Closing out in preference for a new PR, #141

@smit1678 smit1678 closed this Aug 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve indication that you can click to change maps
3 participants