Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Title text image links block #49

Merged
merged 8 commits into from
Nov 23, 2022
Merged

Conversation

conatus
Copy link
Collaborator

@conatus conatus commented Nov 21, 2022

Adds a title + text + image block.

Description

Adds a block that allows for an image, either on the left or the right, a description and a title to be added to pages.

Motivation and Context

Can be found in on the Disasters and Climate Resiliance page of the Figma file.

How Can It Be Tested?

  1. Create an article page.
  2. Add the Title text image block to the mix.
  3. Add your title, description, images and links.
  4. Save and publish the page.

Screenshots (if appropriate):

Sizzy-Desktop localhost 21Nov 15 11

Sizzy-Galaxy Note 10 localhost 21Nov 15 11

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I've checked the spec (e.g. Figma file) and documented any divergences.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I've updated the documentation accordingly.
  • Replace unused checkboxes with bullet points.

@linear
Copy link

linear bot commented Nov 21, 2022

HOT-223

@conatus conatus self-assigned this Nov 21, 2022
@conatus conatus requested a review from janbaykara November 21, 2022 15:16
Copy link
Collaborator

@janbaykara janbaykara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple enough, LGTM (one optional change inline comments)

@@ -0,0 +1,22 @@
{% load wagtailcore_tags %}
{% load wagtailimages_tags %}
<section class="flex flex-col md:flex-row md:justify-between my-16 {% if value.layout == "image_left" %}flex-col-reverse md:flex-row-reverse{% endif %}">
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd add md:items-center (I think?) here so that things can be vertically centered.

@conatus
Copy link
Collaborator Author

conatus commented Nov 21, 2022

Tests failing for some random security problem that I will attempt to fix.

@conatus conatus mentioned this pull request Nov 22, 2022
3 tasks
@conatus conatus merged commit 461cfa7 into main Nov 23, 2022
@conatus conatus deleted the feature/hot-223-title-text-image-block branch November 23, 2022 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants