Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: edit draw AOI in create project #999

Merged
merged 2 commits into from
Nov 22, 2023
Merged

feat: edit draw AOI in create project #999

merged 2 commits into from
Nov 22, 2023

Conversation

varun2948
Copy link
Contributor

@varun2948
feat: edit draw AOI in create project
526c27f 
- fix Edit, delete drawn AOI while project creation #698
- fix User should be able to edit the drawn AOI #950
@varun2948 varun2948 linked an issue Nov 21, 2023 that may be closed by this pull request
User should be able to edit the drawn AOI #950
Closed
@github-actions github-actions bot added the frontend Related to frontend code label Nov 21, 2023
@varun2948 varun2948 self-assigned this Nov 21, 2023
@varun2948 varun2948 requested a review from spwoodcock November 21, 2023 11:01
@spwoodcock spwoodcock merged commit 5f25326 into development Nov 22, 2023
@spwoodcock spwoodcock deleted the 950-user-should-be-able-to-edit-the-drawn-aoi branch November 22, 2023 09:06
@spwoodcock
Copy link
Member

spwoodcock commented Nov 22, 2023 •
edited
Loading

@varun2948 I think this may have introduced a small bug where I can't click to continue after uploading a geojson.

If I refresh /reset the geojson, then upload again, I can proceed with the 'Next' button.

nischalstha9 pushed a commit to naxa-developers/fmtm that referenced this pull request Dec 8, 2023
@varun2948 @pre-commit-ci @nischalstha9
feat(frontend): edit draw AOI in create project (hotosm#999)
c03091e 
* feat: edit draw AOI in create project
- fix Edit, delete drawn AOI while project creation hotosm#698
- fix User should be able to edit the drawn AOI hotosm#950

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spwoodcock spwoodcock Awaiting requested review from spwoodcock

Assignees

@varun2948 varun2948

Labels
frontend Related to frontend code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

User should be able to edit the drawn AOI Edit, delete drawn AOI while project creation
2 participants
@varun2948 @spwoodcock